Conversation
Dropped the local replace block in go.mod that re-routed dappco.re/go/cli and dappco.re/go/i18n to internal/clishim and internal/i18nshim. Both shim trees deleted entirely. Migrated PHP command registration to consume the real upstream packages + core/go's *Core: commands now register via *core.Core / c.Command(...) where appropriate, while the genuine UI helpers (cli.NewStyle, ColourX, SuccessStyle, MinimumNArgs, etc.) keep their dappco.re/go/cli/pkg/cli imports. Added pkg/php/go_cli_helpers.go as a transition layer for the legacy error helpers (phpErr / phpWrap / phpWrapVerb / phpExit) — these still use fmt.Errorf internally and will be migrated to core.E in a follow-up ticket. The shim removal + 0%-replace policy compliance is the load-bearing win in this commit. 27 files changed: build, vet, test all clean. Closes-headline-goal-of: tasks.lthn.sh/view.php?id=1212 Follow-up: migrate go_cli_helpers.go from fmt.Errorf to core.E Co-authored-by: Codex <noreply@openai.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brings v0.3.0 to main: drops the dappco.re/go/{cli,i18n} replace block + clishim/i18nshim trees, migrates command registration to *core.Core. Closes Mantis #1212.